Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activate Reproducible Builds #5

Closed
wants to merge 1 commit into from
Closed

activate Reproducible Builds #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<maven.compiler.release>17</maven.compiler.release>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.outputTimestamp>2024-02-11T10:52:01Z</project.build.outputTimestamp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hboutemy , thanks for the PR.
Since we use git commit-id plugin I think it is more relevant to use last git commit time which will enable to get a dynamic but reproducible build date rather than something we'll likely not maintain manually and which can break the build in time (having a moving build time is key for artifacts).
wdyt?


<tomcat.version>10.1.18</tomcat.version>
<yupiik-logging.version>1.0.7</yupiik-logging.version>
Expand Down