[SynchronizeReleasesToGithubReleases] Tolerate an empty author

yupiik · Dec 28, 2022 · 1f0a118 · 1f0a118
1 parent 504afc2
commit 1f0a118
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/...en-plugin/src/main/java/io/yupiik/maven/mojo/SynchronizeReleasesToGithubReleasesMojo.java b/...en-plugin/src/main/java/io/yupiik/maven/mojo/SynchronizeReleasesToGithubReleasesMojo.java
@@ -246,9 +246,15 @@ private CompletableFuture<?> synchronizeReleases(final HttpClient httpClient, fi
                                     .filter(c -> !c.getCommit().getMessage().startsWith("[maven-release-plugin]") &&
                                             !c.getCommit().getMessage().startsWith("skip changelog"))
                                     .sorted(comparing(it -> OffsetDateTime.parse(it.getCommit().getCommitter().getDate())))
-                                    .map(c -> "" +
-                                            "* [" + c.getCommit().getAuthor().getName() + "](" + c.getAuthor().getHtmlUrl() + "): " +
-                                            c.getCommit().getMessage() + (c.getCommit().getMessage().endsWith(".") ? "" : ".") + " [link](" + c.getHtmlUrl() + ").")
+                                    .map(c -> {
+                                        final var author1 = c.getCommit().getAuthor();
+                                        final var author2 = c.getAuthor();
+                                        return "" +
+                                                "* " + (author2 == null ? author1.getName() : ("[" + ofNullable(author1)
+                                                .map(GithubCommitAuthor::getName)
+                                                .orElseGet(author2::getLogin) + "](" + author2.getHtmlUrl() + ")")) + ": " +
+                                                c.getCommit().getMessage() + (c.getCommit().getMessage().endsWith(".") ? "" : ".") + " [link](" + c.getHtmlUrl() + ").";
+                                    })
                                     .collect(joining("\n")))
                             .thenAccept(msg -> release.setBody(release.getBody() + "\n\n" + msg)))
                     .orElseGet(() -> completedFuture(null))