[minisite] enable to use asciidoctor-java #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to a bug in java desktop, adding a workaround
…e closer to asciidoctor to reuse its css
…a when it is not there
…this later but ultimately we should drop that concept probably + insert <p> more often
fpapon
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Works well, tested on https://www.yupiik.io website generation.
|
@fpapon should we merge that and move the version to 1.2.0-SNAPSHOT since it breaks the minisite asciidoc API? |
Yes, I think it make sense to move to 1.2.0! |
|
@fpapon upgraded the version in the poms, once the build passes, let's merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fpapon we need to discuss it since it is a breaking change for the "asciidoctor pool"