Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk added a dependency rather than a devDependency #31

Closed
jedrichards opened this issue Aug 22, 2019 · 4 comments
Closed

snyk added a dependency rather than a devDependency #31

jedrichards opened this issue Aug 22, 2019 · 4 comments

Comments

@jedrichards
Copy link

Thanks for enabling synk to protect your deps, but I'm guessing it should rather be added as a devDependency, i.e. since it's never used at runtime all your package consumers shouldn't be forced to download it into their node_modules.

https://github.com/YuriGor/deepdash/blob/master/package.json#L85

@YuriGor
Copy link
Owner

YuriGor commented Aug 22, 2019

Hi! Thank you for pointing me to this, you are probably right, I need to dig into this a bit deeper.

I've only accepted a PR generated by Snyk web app, and I have no idea what's the magic is behind, so I need to read some mans and test it before changing.

@jedrichards
Copy link
Author

I suppose snyk is safely added to an app/end-product as a dependency, in that case you're not expecting others to npm install it. But perhaps different story if adding to a library. Anyway, just wanted to give you heads up. Cheers!

@YuriGor
Copy link
Owner

YuriGor commented Aug 23, 2019

Ok, thank you, I'll take a look as soon as I'll have a free minute.

@YuriGor
Copy link
Owner

YuriGor commented Sep 1, 2019

Done in v4.2.14

@YuriGor YuriGor closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants