Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support generic #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support generic #15

wants to merge 3 commits into from
+256 −159

Conversation

caixw
Copy link

@caixw caixw commented Jul 29, 2023

No description provided.

paulvollmer
paulvollmer approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@paulvollmer paulvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulvollmer
Copy link
Contributor

@yuroyoro can you please review as well

@yuroyoro
Copy link
Owner

I think the changes are good. However, I would like the following points to be corrected

  • The title of the PR does not match the changes
  • Upgrading go should be in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulvollmer paulvollmer paulvollmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caixw @paulvollmer @yuroyoro