Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set object as resolved if there are attributes #38

Merged
merged 3 commits into from Jan 17, 2019
Merged

Set object as resolved if there are attributes #38

merged 3 commits into from Jan 17, 2019

Conversation

marcusg
Copy link
Contributor

@marcusg marcusg commented Jan 10, 2019 •
edited

This PR marks all target objects with resolved = true if they contain attributes. It addresses the problem discussed in #29. Now it is possible to differentiate between not yet loaded objects/relationships and loaded ones.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling 6a40f9e on marcusg:mark-resolved into 0da105a on yury-dymov:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling 6a40f9e on marcusg:mark-resolved into 0da105a on yury-dymov:master.

@marcusg marcusg mentioned this pull request Jan 10, 2019
Closed
@yury-dymov
Copy link
Owner

I think this is great, thank you!

@yury-dymov yury-dymov closed this Jan 17, 2019
@yury-dymov yury-dymov reopened this Jan 17, 2019
@yury-dymov yury-dymov merged commit cd78108 into yury-dymov:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcusg @coveralls @yury-dymov