Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add dark mode option for markdown files #30

Closed
DSPaul opened this issue Mar 30, 2023 · 4 comments
Closed

[feature request] Add dark mode option for markdown files #30

DSPaul opened this issue Mar 30, 2023 · 4 comments
Labels

Comments

@DSPaul
Copy link
Contributor

DSPaul commented Mar 30, 2023

The choice of different colour schemes only applies to raw code, the markdown colour scheme is hardcoded to https://cdn.jsdelivr.net/gh/sindresorhus/github-markdown-css@5.1.0/github-markdown-light.min.css. There exists a dark mode equivalent https://cdn.jsdelivr.net/gh/sindresorhus/github-markdown-css@5.1.0/github-markdown-dark.min.css and it would be nice to have the choice to use that one instead.

@yusanshi
Copy link
Owner

It sounds interesting... But the background color for the embeded markdown is white, so I wonder it may look strange to put the dark code on the white background. What do you think? 🤔

@DSPaul
Copy link
Contributor Author

DSPaul commented Mar 30, 2023

Couldn't you just change the background to a dark color in that case? I haven't look to much at your code but all the color schemes for "raw code" change the background color already so I assume there is also a way to do that for the markdown background or am I overlooking something?

@yusanshi
Copy link
Owner

I may need some time to investigate this. Sorry but I'm busy on other stuff these days.

@yusanshi yusanshi added the todo label Mar 30, 2023
@DSPaul
Copy link
Contributor Author

DSPaul commented Mar 30, 2023

No worries, it's not a pressing issue anyway, just a nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants