Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 Improvements #1

Merged
merged 13 commits into from
Sep 26, 2015
Merged

4 Improvements #1

merged 13 commits into from
Sep 26, 2015

Conversation

caseywatts
Copy link
Contributor

This tool is just what I've been looking for! :D
I'd been using http://graphviz-dev.appspot.com/ for a while which is a similar idea, but it was buggy and was finally taken down.

Here are the changes in this PR:

  • use a two-column layout, and make sure the image doesn't overflow (if the single-column layout is better for some situations, let's discuss what those are?)
  • move default example DOT text from the template to the js file, and cache data in the browser's localStorage
  • make polling time 500ms instead of 1000ms (I kept getting the diagram rendered with a trailing letter or two missing)
  • document the README.md more clearly

I realize PRing a few changes in one isn't best - let me know if you like the full set or if you'd rather I just extract some parts of this.

@yushi
Copy link
Owner

yushi commented Sep 24, 2015

Thanks for your interest! I'll take a look this weekend.

@caseywatts
Copy link
Contributor Author

thanks @yushi ! :)

@yushi
Copy link
Owner

yushi commented Sep 26, 2015

Very nice PR. Thank you for many improvements.
I'll release 0.2.0 to npm soon.

yushi added a commit that referenced this pull request Sep 26, 2015
@yushi yushi merged commit ed136ea into yushi:master Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants