-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug report #1
Comments
Dear Peghoty, At 2013-06-06 15:47:26,peghoty notifications@github.com wrote: Dear Yusuke Sugomori, In the C version of your deep learning program, I found a minor bug in DBN_predict (Line 193-200 of the DBN.c file). The initialization of " linear_output" should be moved into the k-loop as follows: for(k=0; ksigmoid_layers[i].n_out; k++) { I guess the same problem may appear in the other versions. Actually, I want to communicate with you for more details about the deep learning algorithm for specifc applications. May I know your email address? peghoty ¡ª |
Hi Peghoty, I think you should go to the author's website (http://yusugomori.com/) to contact him. BTW, as a user I thank you for the bug report. It also occurs in c++ and java versions as I checked. Though I couldn't find the same bug in the python version, the performance of the python version is the same as the undebugged c++ and java version. So I suspect there's a bug in the python version as well, I just didn't find it. I don't know scala, so I didn't touch it. best |
Dear Peghoty, Thank you for the report, and sorry for the delay in replying to you. |
Dear Yusuke Sugomori, Thanks for your reply. I'm a novice of deep learing and read your C code very carefully as a guidence for my studying. May I ask you some more questions?
Thanks again, hope to get your reply soon. Peghoty At 2013-06-23 23:57:48,yusugomori notifications@github.com wrote: Dear Peghoty, Thank you for the report, and sorry for the delay in replying to you. ¡ª |
Same questions here. Thanks! |
I have the same question like above and another question: did you guys test the code?It looks like that the result of predict function is not correct,all the test samples have the same predict value... |
I also faced with such problem on my own testing data, say, all the test samples have the same predict value. Here is a clue for you, though I'm not sure the above problem comes out because of this. As we all know, during the pre-training phase, output of the previous RBM will be taken as input of the current RBM.
In the code of yusugomori/DeepLearning, the second one is used. However, is that really reasonable? Why not use the first one? peghoty At 2013-07-12 10:15:21,samkuok notifications@github.com wrote: I have the same question like above and another question: did you guys test the code?It looks like that the result of predict function is not correct,all the test samples have the same predict value... ¡ª |
thanks,peghoty |
I found that the result of code "ph_sample[i] * input[j] - nh_means[i] * nv_samples[j]" in the contrastive_divergence is always 0,so the weight won't be updated at all. |
Thanks for the bug report. It should be ph_mean[i] * input[j] - nh_means[i] * nv_samples[j] I'll fix that. |
Dear Peghoty, Sorry for the delay.
the sample_v_given_h function has to be changed when coping with real-valued data.
yes, it's for simpicity, and i'm also seeking the best solution... |
Dear Yusuke Sugomori,
In the C version of your deep learning program, I found a minor bug in DBN_predict (Line 193-200 of the DBN.c file). The initialization of " linear_output" should be moved into the k-loop as follows:
I guess the same problem may appear in the other versions.
Actually, I want to communicate with you for more details about the deep learning algorithm for specifc applications. May I know your email address?
peghoty
The text was updated successfully, but these errors were encountered: