TFJ-762 add Application-only authentication feature. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added license notice and @author to some files.
OAuth2Authorization is not a subclass of OAuthAuthorization (and also not implement OAuthSupport), so this change is needed. |
|
LGTM! |
yusuke
added a commit
that referenced
this pull request
Jun 13, 2013
TFJ-762 add Application-only authentication feature.
| return "OAuth2Authorization{" + | ||
| "consumerKey='" + consumerKey + '\'' + | ||
| ", consumerSecret='******************************************\'" + | ||
| ", token=" + token.toString() + |
There was a problem hiding this comment.
This toString() function throws a null pointer exception when called before getOAuth2Token(). IMHO you should strongly considering checking for token==null before calling token.toString()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2.tokenType... Specify 'bearer'.oauth2.accessToken... Specify obtained OAuth 2 Bearer token.oauth2.tokenURL... Specify endpoint of obtaining OAuth 2 Bearer token.oauth2.invalidateTokenURL... Specify endpoint of revoking OAuth 2 Bearer token.enableApplicationOnlyAuth... Specifytrueif you want to use Application-only authentication.