Support slide multiplex #8
Conversation
I am adding all the required configurations and dependencies to enable reveal.js multiplex plugin. When the --multiplex parameter is provided, revealgo adds the /master/ endpoint that renders exactly the same slides, but these ones are able to push their state to the server while the other ones under / follow them. Heads up! This requires an old version of socket.io (v1.6.0) since that is the latest one that github.com/googollee/go-socket.io supports.
| param.Multiplex.IsMaster = true | ||
| http.Handle("/master/", http.StripPrefix("/master", contentHandler(param, http.FileServer(http.Dir("."))))) | ||
| http.Handle("/socketio/", assetsHandler("/assets/", http.FileServer(http.FS(socketiojs)))) | ||
| http.Handle("/socket.io/", socketioServer) |
There was a problem hiding this comment.
I was thinking that the /socketio/ and /revealjs/ handlers could be merged as a single /assets/. But this will require to update all the paths in the slide.html template, which could be a considerable change. If you are alright with that I can do it.
|
Hi, it's me again. I am aware you might be busy, but I realize I might not have checked if you are interested on this feature on the first place. If that is the case, feel free to say "no thanks", I can keep my fork without any problem. Stay safe o/ |
|
Sorry for reply is so late. I tried using revealgo with multiplex feature by your PR's. |
|
Hey @yusukebe I did not mean to rush you, I am sorry for that. But still, I thank you for accepting my contribution |
Background
I have used reveal.js for presentations, and I always have wished to not rely on having a big screen or any sort of projector to do so. The multiplex feature gives the presenter a little more flexibility by letting the audience follow the presentation on their own devices.
Description
I am adding all the required configurations and dependencies to enable reveal.js multiplex plugin.
When the
--multiplexparameter is provided, revealgo adds the/master/endpoint that renders exactly the same slides. Still, these ones can push their state to the server while others under / only follow them.Heads up! This requires an old version of socket.io (v1.6.0) since that is the latest one that
github.com/googollee/go-socket.iosupports 🤷♂️ .NOTE: This is a draft PR since I have a question for you in the commets section.