Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Change inputs syntax #189

Merged
merged 5 commits into from
Nov 17, 2021
Merged

[Breaking change] Change inputs syntax #189

merged 5 commits into from
Nov 17, 2021

Conversation

yutailang0119
Copy link
Owner

@yutailang0119 yutailang0119 commented Sep 8, 2021

ref: #190

@yutailang0119 yutailang0119 self-assigned this Sep 8, 2021
@yutailang0119 yutailang0119 changed the title Use getBooleanInput for input from GitHub Action Change inputs from GitHub Action Sep 8, 2021
@yutailang0119 yutailang0119 marked this pull request as draft September 8, 2021 11:24
@yutailang0119 yutailang0119 changed the title Change inputs from GitHub Action [Breaking change] Change inputs from GitHub Action Sep 8, 2021
@yutailang0119
Copy link
Owner Author

FAIL __tests__/main.test.ts
  ✕ test runs (114 ms)

  ● test runs

    Command failed: node /home/runner/work/action-android-lint/action-android-lint/lib/main.js

      11 |     env: process.env
      12 |   }
    > 13 |   console.log(cp.execSync(`node ${ip}`, options).toString())
         |                  ^
      14 | })
      15 |

      at Object.<anonymous> (__tests__/main.test.ts:13:18)
Error: Input required and not supplied: xml-path
Error: Input does not meet YAML 1.2 "Core Schema" specification: follow-symbolic-links%0ASupport boolean input list: `true | True | TRUE | false | False | FALSE`

@yutailang0119 yutailang0119 changed the title [Breaking change] Change inputs from GitHub Action [Breaking change] Change inputs syntax Sep 8, 2021
@yutailang0119
Copy link
Owner Author

Re #189 (comment)
resolve by #253

@yutailang0119 yutailang0119 marked this pull request as ready for review November 17, 2021 13:26
@yutailang0119 yutailang0119 merged commit 4e740f0 into main Nov 17, 2021
@yutailang0119 yutailang0119 deleted the cleanup/input branch November 17, 2021 13:26
@yutailang0119 yutailang0119 added the breaking change Breaking Change label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant