-
Notifications
You must be signed in to change notification settings - Fork 25
Fix routing problem #36
Conversation
Original Issue: fastapiutils#154 Credit: WouldYouKindly <https://github.com/WouldYouKindly> If we use class-based routing, the cbv causes the double routes. WouldYouKindly solves the problem, but he does not the patch to the repo. I really need the patch for my daily development so I copy his solution to resolve. If it causes anyone feels uncomfortable, I will delete my PR. Sorry for the copy
|
is there any update for that pr? |
|
Looking forward to this PR being accepted. Having the same issue. |
|
It doesn't passes tests, so I first need to figure whats going on there, |
|
I think the first test failing should be /items? instead of /items/? |
|
Any news on getting these tests fixed? |
|
I was lacking the update, The new code create an issue where @router.get as decorator doesn't works which means:
I can try to fix the fork so it won't drop the multiple routes functionality but I'm lacking the time so I don't know how much time it is going to take, anyway I'm starting it now EDIT: |
Original issue: fastapiutils#154
Credit: WouldYouKindly https://github.com/WouldYouKindly
If we use class-based routing, the cbv causes the double routes.
WouldYouKindly solves the problem, but he does not the patch to the
repo. I really need the patch for my daily development so I copy his
solution to resolve.
If it causes anyone feels uncomfortable, I will delete my PR.
Sorry for the copy