Implement support for init containers and extra volumes/mounts for ssh #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An example for it is using the service to access a JupyterHub instance that is behind a PKI based certificate.
consideRatio
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Thanks!
I think the indentation needed some tweaks, and that the schema needs to be updated. See https://github.com/yuvipanda/jupyterhub-ssh/blob/main/helm-chart/jupyterhub-ssh/schema.yaml.
|
You're welcome ! I added the new fields to the schema but there are several others that are not documented. Since they are unrelated to this change, should they be added in a separate MR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the service itself does not require them, there are situations that may.
The example at hand is connecting to a JupyterHub instance that uses a custom certificate authority.
To the best of my knowledge there are two solutions:
This patch implements the latter as it avoids creating new images just for that purpose and the additional certificates can be easily changed using a central storage.