-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title Bar Customization #90
Conversation
@yuxshao In this latest commit, I had a conflict between some Cocoa stuff and the |
At the moment I'm just waiting to verify it works as intended in Windows 10, and after that it will be ready for review |
Add forgotten parameters & explain in detail the [platform] section
macOS build is failing because I can't get the qmake to work with the include precedence. Something about the Objective C++ upsets the compiler in the way it's ordered when using qmake & all of the declarations made in StyleEditor.h are unavailable from the C++, since the compiler interpreted the header as Obj-C++. I never had this issue when using cmake |
… at normal 96 dpi :(
…so every (appropriate) window gets its attributes set right
@@ -33,6 +33,22 @@ struct InvalidColorError { | |||
QString setting; | |||
}; | |||
|
|||
template <typename T> | |||
void withSettingsValue(const QSettings &settings, const QString &key, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny thing, I don't think you need this withSettingsValue thing that takes in a variable function if you're only going to use it once. withSettingsColor was needed becuase in one case it was setting a QColor ref, and in the other it was setting a value in a QPalette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may use it more than just for bool in the future. no harm in having a templated solution if it's the same amount of new code as writing a bool specific version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait do you mean the function parameter is not needed. i feel like we should probably keep it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! just would be good to know about the magic numbers in case of need to change / adjust in the future
Adds the
platform
section to config.ini, with settingsWindowBorder
,WindowText
,WindowCaption
, andWindowDark
Windows <10, Linux DEs
Windows 11
WindowCaption
WindowBorder
WindowText
WindowDark
(visible ifWindowCaption
isn't set)Windows 10
WindowDark
macOS
WindowCaption
#00FF00
becomes#00F900
and#1F1F1F
becomes#292929
. ExamplesSet title bar border color based onWindowBorder
Set title bar text color based onWindowText
Set dark title bar for based onWindowDark
(visible ifWindowCaption
isn't set)All
Goals with strikethrough are not possible for whatever reason