Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not mmap model files + use RegisterCustomOpsLibrary_V2 #149

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

yuzawa-san
Copy link
Owner

  • java seems to have some oddness around MappedByteBuffer which may cause crashes
  • fully delegate to CreateSession for file loading
  • use RegisterCustomOpsLibrary_V2 so we dont need to release later (since that is handled internally)

@yuzawa-san yuzawa-san added the bug Something isn't working label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e69549b) 0.00% compared to head (9d42e0e) 81.13%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #149       +/-   ##
=============================================
+ Coverage          0   81.13%   +81.13%     
- Complexity        0      323      +323     
=============================================
  Files             0       49       +49     
  Lines             0     1362     +1362     
  Branches          0       86       +86     
=============================================
+ Hits              0     1105     +1105     
- Misses            0      223      +223     
- Partials          0       34       +34     
Files Coverage Δ
src/main/java/com/jyuzawa/onnxruntime/ApiImpl.java 97.72% <100.00%> (ø)
...main/java/com/jyuzawa/onnxruntime/SessionImpl.java 88.41% <66.66%> (ø)

... and 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuzawa-san yuzawa-san merged commit 5c9dbf5 into master Oct 2, 2023
5 checks passed
@yuzawa-san yuzawa-san deleted the file-loads branch October 2, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant