refactor/organizing a bit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdcoffey
approved these changes
Sep 12, 2022
| const initialWatchList = ["S:VTI", "S:SPY", "C:BTC-USD"]; | ||
|
|
||
| type WatchListProps = { | ||
| wlLoading: boolean; |
There was a problem hiding this comment.
Just an idea: one thing I've seen done before when you don't want to pass a whole bunch of data up and down the component stack is to use graphql-batch-loader which allows you to break up a huge graphql query and place the relevant pieces inside the components that need them, and then the link will batch them all up. Not saying we should do that now, just pointing it out as an option if this pattern becomes annoying to manage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out queries and components out of App.tsx to add a little organization