-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kroki does not render included PlantUML sprites #33
Comments
Hello @vainikkaj I've decided to prune However I'm willing to include collections of sprites and macros for well-known services like AWS or Azure and/or add a whitelist of URLs. |
Apparently Azure is already available in the stdlib: http://plantuml.com/fr/stdlib |
The following does not work on http://plantuml.com: @startuml
!pragma revision 1
'!define AzurePuml https://raw.githubusercontent.com/RicardoNiepel/Azure-PlantUML/master/dist
'!includeurl AzurePuml/AzureRaw.puml
'!includeurl AzurePuml/Databases/AzureCosmosDb.puml
'!includeurl AzurePuml/Compute/AzureFunction.puml
component "<color:red><$AzureFunction></color>" as myFunction
database "<color:#0072C6><$AzureCosmosDb></color>" as myCosmosDb
rectangle "<color:AZURE_SYMBOL_COLOR><$AzureCosmosDb></color>" as mySecondCosmosDb
AzureFunction(mySecondFunction, "Stream Processing", "Consumption")
myFunction --> myCosmosDb
mySecondFunction --> mySecondCosmosDb
@enduml But the following do (because Azure is available in the stdlib): @startuml
!pragma revision 1
!include <azure/AzureRaw>
!include <azure/Databases/AzureCosmosDb>
!include <azure/Compute/AzureFunction>
component "<color:red><$AzureFunction></color>" as myFunction
database "<color:#0072C6><$AzureCosmosDb></color>" as myCosmosDb
rectangle "<color:AZURE_SYMBOL_COLOR><$AzureCosmosDb></color>" as mySecondCosmosDb
AzureFunction(mySecondFunction, "Stream Processing", "Consumption")
myFunction --> myCosmosDb
mySecondFunction --> mySecondCosmosDb
@enduml |
Hi @Mogztter I think it's security-wise ok to trust that the content of embedded stdlib is safe and enable I agree that |
resolves #33 preserve stdlib includes
It's fixed and available at https://kroki.io |
@vainikkaj Does it work for you? |
👍 |
Thanks for your feedback, I'm glad it's working for you 😉 |
@Mogztter Hi (again), this time just a comment :-) Your security argument against => Maybe allow an env var like PS: Your productivity is... depressing ;-) |
Indeed we could enable this feature for self hosted server. @axgkl Could you please open another issue with this feature request? Thanks!
😉
We could also enable this feature on self hosted server. Not sure if it should be enabled by default or not. |
Given following image is given to Kroki
Then rendering ends with following error message
Error 400: Syntax Error? (line: 12)
Image will be rendered when
AzureFunction
line removed but even then all sprites are missing.Below is a link how the image should look in Kroki
http://www.plantuml.com/plantuml/uml/XL5FRzem5B_xKvXiqZPf4BR39g4eWeNr10K5SMWloDYlmL9iH_Ppg_RJrv0QIbhQet__hJTso2nwLPDUOrcb6BLmBvqqcluYv5jFm9tKG2TFti8ooEWEiN6ZDBNiOL19tFcjTs2vqGWQ1zoej9ISMM6k9JHGfmTdVrapZUlvB5NC8TXKI8SXNMfUUm7UrgU6rb66-2QyBecc3DcMEN2jl31E6JVTVkWfZ6eyGkkuyffZ-6Rh8D51CxPdZoFoBdEf-Otm_RgS41vmeq4ZJJ9kQcD75aIUVJtNPUc1onFA75MF4IVYfVve_Z8S_lrT_8a1SKyt8EB40aUcg_gKCBbTb_ytgvlvlyLiKoncY_Api1M4Wul8ahFbtoCTWPyqMQ45fkZI6WxEILqb0IoCTburUqdoWv3J7sc_dxzU70CxV6V46BG8ftm6
The text was updated successfully, but these errors were encountered: