New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ubuntu base image for main container #1476
Use Ubuntu base image for main container #1476
Conversation
@ggrossetie I'm getting the following error related to
What's puzzling me is that
Do you know why this was done? I'm not really familiar with Node.js but it seems like the the Vega |
As far as I remember, canvas is an external dependency. I don't recall exactly why but https://github.com/vercel/pkg cannot include it inside the
|
@ggrossetie I found a way to include the |
@felixvanoost Nice! Let's see how it goes on the CI. |
This is ready to merge from my side. If approved, I'll use this as the starting point for creating an |
Thanks, I will take a closer look this week-end. |
LGTM, thanks again for your contribution 👌🏻 |
Replaces the base Docker image for
yuzutech/kroki
(eclipse-temurin:11.0.17_8-jre-alpine
) with the Ubuntu flavour of the latest JRE 11 image (eclipse-temurin:11.0.18_10-jre-jammy
). This variant has botharm64
andamd64
variants available, which should resolve one of the last remaining roadblocks to adding native ARM support to Kroki.The use of a Ubuntu base image may have some other secondary advantages as well, e.g. more widespread support during development/debugging.
Notes:
graphviz
available usingapt
(2.42.2) is behind the latest version available usingapk
(3.00.0), so there may be some unexpected consequences from this change.