Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2 diagrams: document option 'sketch' #1558

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

deining
Copy link
Contributor

@deining deining commented May 31, 2023

This PR adds documentation for the newly added option 'sketch' for D2 diagrams.

Side note: https://docs.kroki.io hasn't deployed for quite some time now, documentation changes that are present for quite some time now are not reflected yet. Could you please regenerate the Antora based docs? Thanks!

@ggrossetie
Copy link
Member

Side note: https://docs.kroki.io/ hasn't deployed for quite some time now, documentation changes that are present for quite some time now are not reflected yet. Could you please regenerate the Antora based docs? Thanks!

Everything looks good. Latest deployment was 2 weeks ago (1e88a8c). Could you please tell me where you see outdated content?

@deining
Copy link
Contributor Author

deining commented Jun 2, 2023

Everything looks good. Latest deployment was 2 weeks ago (1e88a8c). Could you please tell me where you see outdated content?

Open [https://docs.kroki.io/kroki/setup/diagram-options/)https://docs.kroki.io/kroki/setup/diagram-options/[https://docs.kroki.io/kroki/setup/diagram-options/).

First table, second row, second column:

Name Allowable values
antialias boolean
true, false

while the source tells:

Name Allowable values
antialias flag
empty string ""

@ggrossetie
Copy link
Member

It seems that Netlify is using an aggressive cache and doesn't actually deploy the latest version 😞
I had to clear cache and redeploy... 😒

Anyway, thanks for the heads-up!

@ggrossetie
Copy link
Member

Let's see if your change will be automatically deployed (or not)

@ggrossetie ggrossetie merged commit 147d832 into yuzutech:main Jun 2, 2023
3 checks passed
ggrossetie added a commit that referenced this pull request Jun 2, 2023
ggrossetie added a commit that referenced this pull request Jun 2, 2023
@ggrossetie
Copy link
Member

Ooops merged too fast, this option is already present in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants