perf: xml query refactoring

Benchmark shows perf. boost for the String data type on big collections.
yv989c · May 19, 2023 · 88b7068 · 88b7068
1 parent 17170eb
commit 88b7068
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/QueryableValues.SqlServer/SqlServer/XmlQueryableFactory.cs b/src/QueryableValues.SqlServer/SqlServer/XmlQueryableFactory.cs
@@ -41,7 +41,7 @@ protected override string GetSqlForComplexTypes(IEntityOptionsBuilder entityOpti
                 sb
                     .Append("\tI.value('@")
                     .Append(QueryableValuesEntity.IndexPropertyName)
-                    .Append("[1] cast as xs:integer?', 'int') AS [")
+                    .Append(" cast as xs:integer?', 'int') AS [")
                     .Append(QueryableValuesEntity.IndexPropertyName)
                     .Append(']');
 
@@ -54,7 +54,7 @@ protected override string GetSqlForComplexTypes(IEntityOptionsBuilder entityOpti
 
                     var targetName = mapping.Target.Name;
 
-                    sb.Append("\tI.value('@").Append(targetName).Append("[1] cast as ");
+                    sb.Append("\tI.value('@").Append(targetName).Append(" cast as ");
 
                     switch (mapping.TypeName)
                     {
@@ -122,7 +122,7 @@ protected override string GetSqlForComplexTypes(IEntityOptionsBuilder entityOpti
                 }
 
                 sb.AppendLine();
-                sb.Append("FROM {0}.nodes('/R/V') N(I)").AppendLine();
+                sb.Append("FROM {0}.nodes('/R[1]/V') N(I)").AppendLine();
                 sb.Append("ORDER BY [").Append(QueryableValuesEntity.IndexPropertyName).Append(']');
 
                 return sb.ToString();