Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request): Change IncomingMessage to be a Readable Stream #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcollien
Copy link

@dcollien dcollien commented Mar 6, 2019

Changing IncomingMessage to a Readable stream allows body-parser to work correctly
Fixes: #22 #15

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          67     67           
  Branches       18     18           
=====================================
  Hits           67     67
Impacted Files Coverage Δ
src/IncomingMessage.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd9041...929ca7e. Read the comment docs.

@sinedied
Copy link

Could this PR me merged? It's really a blocking issue...
@yvele ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http body already parsed
3 participants