Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out sections in TPCC #11

Closed
ghost opened this issue Oct 18, 2017 · 2 comments
Closed

Commented out sections in TPCC #11

ghost opened this issue Oct 18, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 18, 2017

Hi, I'm looking at DBx1000's implementation of "new order" transactions in TPCC, and came across the following line:

// XXX district info is not inserted.

The commented-out section that comes below inserts to the order line table, which is required by TPCC. Is it a bug?

It also appears to me that the benchmarks in DBx1000 don't exercise insert_row() in any index structures, but the indexes themselves seem functional. Is this intended?

@yxymit
Copy link
Owner

yxymit commented Oct 19, 2017

Hi Yihe,

We disabled inserts in TPC-C in order to keep the memory footprint low. We found that with inserts, the program can quickly run out of memory. Disabling inserts is ok for us since inserts were not the main focus of our previous research. If you want to study performance for indexes, you should uncomment those lines. The hash index should work properly with inserts/deletes. We haven't tested the B-tree index for a while; so be careful with B-tree since there might be bugs.

Best,
Xiangyao

@ghost
Copy link
Author

ghost commented Oct 20, 2017

Thanks for the clarification Xiangyao!

@ghost ghost closed this as completed Oct 20, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant