Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decoration parameter, in many cases backgroundColor is not enough. #26

Closed
slavap opened this issue Jan 29, 2020 · 4 comments
Closed

Add decoration parameter, in many cases backgroundColor is not enough. #26

slavap opened this issue Jan 29, 2020 · 4 comments

Comments

@slavap
Copy link
Contributor

slavap commented Jan 29, 2020 •
edited

Currently decoration is just hardcoded:

decoration: BoxDecoration(
                  borderRadius: BorderRadius.circular(borderRadius),
                  color: backgroundColor,
                ),
@AndroidHensen
Copy link
Contributor

Can you provide a feasible solution

@slavap
Copy link
Contributor Author

slavap commented Jan 30, 2020 •
edited

Do you mean pull request?

Created PR, please accept.

@slavap
Copy link
Contributor Author

slavap commented Jan 31, 2020

Fixed with #28

@slavap slavap closed this as completed Jan 31, 2020
@AndroidHensen
Copy link
Contributor

support in v1.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slavap @AndroidHensen