Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Format #95

Closed
elipriaulx opened this issue Jul 12, 2018 · 2 comments · Fixed by #172
Closed

Date Format #95

elipriaulx opened this issue Jul 12, 2018 · 2 comments · Fixed by #172

Comments

@elipriaulx
Copy link

elipriaulx commented Jul 12, 2018

<span class='date'></span> used in the header template doesn't respect my system date format, and I can't see any way to override the format in the available options.

MDY format is not the default interpretation for most of the world, and month/day ambiguity is a huge issue.

@kmindi
Copy link

kmindi commented Jul 26, 2018

I agreee, per default it should use the ISO 8601 format: yyyy-mm-dd and it should be configurable.

@ghost
Copy link

ghost commented Nov 26, 2018

I changed my local copy of the extension and added the following property to the Puppeteer options object at Line 370 of extension.js:

args: ['--lang=en-AU']

See Line 370 here:

executablePath: vscode.workspace.getConfiguration('markdown-pdf')['executablePath'] || undefined

I found this approach here: puppeteer/puppeteer#1871

I'm not sure how you would make it use the system default - I searched for how to do this, but didn't have any luck. It's a crude, but effective workaround. Hope this helps someone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants