fix: nullable property

yzen-dev · Jul 12, 2023 · 1f01828 · 1f01828
1 parent 5f78b33
commit 1f01828
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "yzen.dev/plain-to-class",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "description": "Class-transformer to transform your dataset into a structured object",
   "minimum-stability": "dev",
   "prefer-stable": true,

diff --git a/composer.lock b/composer.lock
diff --git a/src/ValueCasting.php b/src/ValueCasting.php
@@ -47,7 +47,7 @@ public function __construct(ReflectionProperty $property, HydratorConfig $config
      */
     public function castAttribute(mixed $value): mixed
     {
-        if ($this->property->type->isNullable && empty($value)) {
+        if ($this->property->type->isNullable && $value === null) {
             return null;
         }
 

diff --git a/tests/Units/ValueCastingTest.php b/tests/Units/ValueCastingTest.php
@@ -50,19 +50,19 @@ public function testCreateProperty(): void
 
 
         $caster = new ValueCasting(new RuntimeReflectionProperty(new \ReflectionProperty(TypesDto::class, 'nullableInt')));
-        $value = $caster->castAttribute('');
+        $value = $caster->castAttribute(null);
         $this->assertNull($value);
 
         $caster = new ValueCasting(new RuntimeReflectionProperty(new \ReflectionProperty(TypesDto::class, 'nullableString')));
-        $value = $caster->castAttribute('');
+        $value = $caster->castAttribute(null);
         $this->assertNull($value);
 
         $caster = new ValueCasting(new RuntimeReflectionProperty(new \ReflectionProperty(TypesDto::class, 'nullableFloat')));
-        $value = $caster->castAttribute('');
+        $value = $caster->castAttribute(null);
         $this->assertNull($value);
 
         $caster = new ValueCasting(new RuntimeReflectionProperty(new \ReflectionProperty(TypesDto::class, 'nullableBool')));
-        $value = $caster->castAttribute('');
+        $value = $caster->castAttribute(null);
         $this->assertNull($value);
     }