Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor VS Code's action #1069

Open
Lemmingh opened this issue Jan 13, 2022 · 5 comments
Open

Monitor VS Code's action #1069

Lemmingh opened this issue Jan 13, 2022 · 5 comments
Labels
Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. Upstream Pertaining to an upstream component, or blocked by an upstream issue.

Comments

@Lemmingh
Copy link
Collaborator

Background

@yzhang-gh

I'm aware that you are also actively watching VS Code's repository.

Instead of editing existing issues silently, let's make explicit notifications when VS Code changes.

Proposal

If the change suits a topic that we're already discussing, add a comment there. e.g., the vscode.markdown-math case in #955

If the change brings us new problems, open a dedicated issue. e.g., #1008

Else, post a short message in this thread to inform everyone as soon as possible, hoping someone who can anticipate the impact will create an issue.

@Lemmingh Lemmingh added Upstream Pertaining to an upstream component, or blocked by an upstream issue. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. labels Jan 13, 2022
@Lemmingh
Copy link
Collaborator Author

Impressive. But VS Code's solution is still powered by TextMate grammar which can never properly express Markdown syntax. As it's "strikethrough", incorrect syntax highlighting by vscode.markdown can be more annoying.

Here are perhaps two tasks for us:

  • Add another piece to the docs.

  • Give priority to Semantic Highlighting.

@Lemmingh
Copy link
Collaborator Author

Matt Bierner is skilled at VS Code API, and his code may become a clue to our long-standing problems.

But it's still unclear what "simple path IntelliSense" refers to. The development suddenly began a few hours ago.

@yzhang-gh
Copy link
Owner

Not sure whether we should still have this in our extension (we don't have to). I assume TextMate may be good enough for most users. Let's see how it works out.

@Lemmingh
Copy link
Collaborator Author

TextMate grammar has severe limitations. It even cannot express lots of CFG.

AFAIK, there're many tricky (usually unsolvable) problems in

I suggest revisiting the topic later.

@Lemmingh
Copy link
Collaborator Author

Lemmingh commented Apr 5, 2022

Wow, Matt is rushing fast. Hope that they won't take error-prone RegExp-based approaches this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. Upstream Pertaining to an upstream component, or blocked by an upstream issue.
Projects
None yet
Development

No branches or pull requests

2 participants