Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle bold or italic on a word without selecting it #19

Closed
borekb opened this issue Jul 18, 2017 · 9 comments
Closed

Toggle bold or italic on a word without selecting it #19

borekb opened this issue Jul 18, 2017 · 9 comments
Labels
Area: Basic formatting Toggling bold, italic, etc. (Basic rich text editing features) No sure if it's an intuitive name. Issue: Enhancement Improvements in existing features. Res: Fixed Fix is checked in, but it might be a few weeks until a release.

Comments

@borekb
Copy link

borekb commented Jul 18, 2017

w|ord -> press Ctrl+B -> **w|ord**
@yzhang-gh yzhang-gh added Issue: Feature Something brand new. Issue: Enhancement Improvements in existing features. and removed Issue: Feature Something brand new. labels Jul 18, 2017
@yzhang-gh
Copy link
Owner

yzhang-gh commented Jul 18, 2017 •
edited

Let's consider the corner cases. What do you expect in these situations. 🤔

some| words
some |words

@borekb
Copy link
Author

borekb commented Jul 18, 2017

Tried in Caret, my favorite MD editor that does many things well, and this is the result:

**some** words
some **words**

@yzhang-gh
Copy link
Owner

👌

@yzhang-gh
Copy link
Owner

One small question. Where is the cursor after ctrl+b?

@borekb
Copy link
Author

borekb commented Jul 18, 2017

It's here:

**some**| words
some |**words**

@yzhang-gh
Copy link
Owner

I will introduce a new setting quickStyling for these behaviors.

For the reason, it conflicts with our original logic. You can see some discussion here. What do you think of it?

@borekb
Copy link
Author

borekb commented Jul 18, 2017

I'd generally follow what other MD editors do. I think that most often, Ctrl+B and Ctrl+I just toggles. I personally do not need anything fancier.

@yzhang-gh
Copy link
Owner

Actually, I have implemented it for a period of time.
But I would like to add unit tests before releasing this feature.
And then I am blocked 😓.

@borekb
Copy link
Author

borekb commented Jul 21, 2017

Looking forward to it :)

@yzhang-gh yzhang-gh mentioned this issue Jul 26, 2017
Closed
@Lemmingh Lemmingh changed the title Wrap word in bold or italics if no selection Toggle bold or italic on a word without selecting it Nov 24, 2021
@Lemmingh Lemmingh mentioned this issue Nov 26, 2021
Merged
@Lemmingh Lemmingh added Area: Basic formatting Toggling bold, italic, etc. (Basic rich text editing features) No sure if it's an intuitive name. Res: Fixed Fix is checked in, but it might be a few weeks until a release. labels Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Basic formatting Toggling bold, italic, etc. (Basic rich text editing features) No sure if it's an intuitive name. Issue: Enhancement Improvements in existing features. Res: Fixed Fix is checked in, but it might be a few weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@borekb @yzhang-gh @Lemmingh