Fix enter key behavior on - [x] |item1
#1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I agree with you as Word seems to have the same behavior. Could you add a few comments about the decision logic in the source code? It will be helpful to understand the context if we revisit it in the future. |
|
I've added some comments. |
|
Looks perfect. I will merge it as soon as the previous PRs are resolved. |
yzhang-gh
approved these changes
Jun 25, 2022
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case
- [x]should be moved to the next line.This change makes
markdown.extension.onEnterKeyto move- [x]if the cursor is right after- [x].This is another use case.