Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LSCP and a set of fixes #38

Merged
merged 21 commits into from Dec 6, 2018
Merged

Added LSCP and a set of fixes #38

merged 21 commits into from Dec 6, 2018

Conversation

yzhao062
Copy link
Owner

@yzhao062 yzhao062 commented Dec 6, 2018

  1. LSCP model is added
  2. Bug fixes and documentation improvement

ZainNasrullah and others added 21 commits December 1, 2018 22:48
@ZainNasrullah
1) added documentation
abf37e5 
2) fixed bug where max_features wasn't being used
@ZainNasrullah
-moved bagging indices utility functions to utility.py
61e8a29 
-updated example to prevent overfitting
-removed unnecessary code
@ZainNasrullah
created lscp model, example and test
9f784a0
@ZainNasrullah
removed unused libraries and residuals from lscp model
4c17360
@ZainNasrullah
removed os and sys (not in use)
d2b92cf
@ZainNasrullah
minor refactoring
d13f91f
@ZainNasrullah
minor refactoring on temp file
f360428
@ZainNasrullah
moved random_state to fit and changed random state validation
5d587a1 
to use sklearn check_random_state
@ZainNasrullah
raise warning is local region size is outside recommended range
723b3ca
@ZainNasrullah
moved histogram bin check to when constructing the histogram
8fbf236
@ZainNasrullah
moved local max features and estimator list checks to
190b2b1 
their corresponding locations
@ZainNasrullah
moved max features outside init
e82f1cb
@ZainNasrullah
Merge branch 'temp' into lscp_implementation
f3422f0 
# Conflicts:
#	pyod/models/lscp.py
@ZainNasrullah
work around for random state bug in example (find root cause later)
3267e70
@ZainNasrullah
refactored 'estimator' --> 'detector'
a55b9c1
@yzhao062
Merge pull request #31 from yzhao062/lscp_implementation
eeafb51 
LSCP implementation
@yzhao062
Pre-release XGBOD (wip)
aa14596
Merge branch 'development' of https://github.com/yzhao062/Pyod into d…
2e86952 
…evelopment
@yzhao062
clean-up LSCP file
014ae10
Minor name difference fixes
9d05bbc
@yzhao062
New version Pre-release
6caf743
@yzhao062 yzhao062 merged commit 1fcecea into master Dec 6, 2018
@coveralls
Copy link

coveralls commented Dec 8, 2018 •
edited

Pull Request Test Coverage Report for Build 421

  • 195 of 290 (67.24%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 92.643%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/test/test_lscp.py 86 87 98.85%
pyod/utils/utility.py 12 13 92.31%
pyod/models/lscp.py 97 104 93.27%
pyod/models/xgbod.py 0 86 0.0%
Totals Coverage Status
Change from base Build 414: -2.6%
Covered Lines: 2934
Relevant Lines: 3167
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yzhao062 @coveralls @ZainNasrullah