Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mo_gaal Tensorflow -> Pytorch #577

Merged
merged 19 commits into from
Jun 21, 2024
Merged

mo_gaal Tensorflow -> Pytorch #577

merged 19 commits into from
Jun 21, 2024

Conversation

zhuox5
Copy link
Contributor

@zhuox5 zhuox5 commented May 21, 2024

I have tried to convert the mo_gaal model from Tensorflow to Pytorch. I didn't create a new test_mo_gaal.py because the original one works well.

In mo_gaal(Pytorch version), instead of keeping consistent with default hyper-parameter value as of the tensorflow version, I did tuning it and add a dynamic tuner in the model.

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

  • Have you created a .py in ~/pyod/models/?
  • Have you created a _example.py in ~/examples/?
  • Have you created a test_.py in ~/pyod/test/?
  • Have you lint your code locally prior to submission?

@coveralls
Copy link

coveralls commented May 21, 2024

Pull Request Test Coverage Report for Build 9619494502

Details

  • 92 of 98 (93.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 94.171%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/models/mo_gaal.py 63 69 91.3%
Totals Coverage Status
Change from base Build 9619087701: 0.09%
Covered Lines: 9370
Relevant Lines: 9950

💛 - Coveralls

@zhuox5 zhuox5 closed this Jun 4, 2024
@zhuox5 zhuox5 reopened this Jun 4, 2024
@zhuox5
Copy link
Contributor Author

zhuox5 commented Jun 5, 2024

The github client issue doesn't happen yesterday to me but does again today:(

@yzhao062 yzhao062 merged commit 1c0b78d into yzhao062:development Jun 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants