Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make readme badges be on one line #580

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

andrewm4894
Copy link
Contributor

@andrewm4894 andrewm4894 commented May 28, 2024

Just a small PR to make the readme badges be on one line.

I was just sharing with a colleague and noticed the badges seem to each be on thier own line in the github readme. Thought could be an easy one for me to try see if can make a little prettier potentially as i love the project.

Can quickly see how it will look here: https://github.com/andrewm4894/pyod/blob/patch-1/README.rst

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

  • Have you created a .py in ~/pyod/models/?
  • Have you created a _example.py in ~/examples/?
  • Have you created a test_.py in ~/pyod/test/?
  • Have you lint your code locally prior to submission?

i think it looks a bit nicer in the GitHub readme if they are on one line
@andrewm4894 andrewm4894 changed the title make readme badges be one one line make readme badges be on one line May 28, 2024
@andrewm4894 andrewm4894 marked this pull request as ready for review May 28, 2024 17:08
@coveralls
Copy link

coveralls commented May 29, 2024

Pull Request Test Coverage Report for Build 9273495780

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.73%

Totals Coverage Status
Change from base Build 8309424051: -0.02%
Covered Lines: 8954
Relevant Lines: 9553

💛 - Coveralls

@andrewm4894
Copy link
Contributor Author

Maybe coverage has gone down a little due to deleting a few lines from the readme? Would have thought not, although maybe .rst files can impact this.

@yzhao062
Copy link
Owner

oh, it is a GitHub issue. no worries. please make the PR to the development branch :)

@andrewm4894 andrewm4894 changed the base branch from master to development May 31, 2024 13:37
@yzhao062 yzhao062 merged commit 163b268 into yzhao062:development Jun 1, 2024
13 of 15 checks passed
@andrewm4894 andrewm4894 deleted the patch-1 branch June 5, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants