Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sod implementation #74

Merged
merged 8 commits into from
Jun 12, 2019
Merged

Sod implementation #74

merged 8 commits into from
Jun 12, 2019

Conversation

John-Almardeny
Copy link
Contributor

@John-Almardeny John-Almardeny commented Apr 15, 2019

All Submissions Basics:

#60

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

  • Have you created a .py in ~/pyod/models/?
  • Have you created a _example.py in ~/examples/?
  • Have you created a test_.py in ~/pyod/test/?
  • Have you lint your code locally prior to submission?

Description

@coveralls
Copy link

coveralls commented Apr 15, 2019

Pull Request Test Coverage Report for Build 957

  • 158 of 159 (99.37%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.649%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/test/test_sod.py 103 104 99.04%
Totals Coverage Status
Change from base Build 956: 0.1%
Covered Lines: 3979
Relevant Lines: 4160

💛 - Coveralls

@yzhao062
Copy link
Owner

If the PR is in the good state, could you submit the PR to development branch? Thanks, Yue

@John-Almardeny John-Almardeny changed the base branch from master to development April 16, 2019 19:10
@John-Almardeny
Copy link
Contributor Author

@yzhao062 Oops I just missed this. I changed the base now to development.

@John-Almardeny
Copy link
Contributor Author

Hi Yue @yzhao062
I am happy with it now.
Please consider checking this PR.
Kind Regards,
Yahya.

@yzhao062 yzhao062 merged commit c316f36 into yzhao062:development Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants