Add initial docker support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use docker for everything so this commit adds initial docker support to allow me to test changes to the code quickly.
GaryChicago
reviewed
Jul 19, 2018
| @@ -0,0 +1,1953 @@ | |||
| { | |||
There was a problem hiding this comment.
package-lock.json needed?
There was a problem hiding this comment.
It's generally good practice to commit these as they lock in packages at versions you know they're working at. It also helps you know when packages have changed since it may not be apparent when you make updates.
There was a problem hiding this comment.
Oh, I forgot the most important reason for these -- they make npm install fast.
There was a problem hiding this comment.
Okay great. Just wanted to know.
GaryChicago
reviewed
Jul 19, 2018
GaryChicago
approved these changes
Jul 19, 2018
|
I don't mind questions for now. It'll help us understand the best use-case and build that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use docker for everything so this commit adds a couple of things to allow me to test changes to the code quickly: