-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor detection bug #60
Comments
Thanks for the report. It seems the results of fuzzy search are becoming apparent. Can you please give me the filenames of the episodes that get mixed up? |
Well, it's simply because HorribleSubs uses Mahouka as its name, while the official MAL name is "Mahouka Koukou no Rettousei". Making a fuzzy search on alternative titles as well as official titles make this a non-issue, as Mahouka is listed in its alt titles. |
Which service are you using? MAL doesn't list it as an alternative title.
|
Wow, sorry, it really isn't. This is weird, since I modified engine.py to compare to the alternative titles before, it was recognizing it correctly, so I assumed it was in its alternative titles. Edit: Well, we could add a small amount to the ratio if the file contains a substring of the title/alt-title. E.g. add 0.5 to the ratio if the filename is contained in the title ("Mahouka" in "Mahouka Koukou no Rettousei" or "Argevollen" in "Shirogane no Ishi: Argevollen"). |
Sorry about the delay, the file in question was [HorribleSubs] Mahouka - 12 [720p].mkv, which the search indicated as new Hyouka episode. |
I see. Since "Mahouka" isn't listed as an alternative by the MAL database, even if I tried to remedy this the tracker, instead of confusing it with Hyouka, it just wouldn't find it at all. The best thing you can do is to set "Mahouka" as the alternative title yourself (can be done in wmal-qt by selecting the show, and going into Show -> Set alternative title), which is a workaround for these specific cases. The tracker uses a ratio number (currently 0.7) for the fuzzy search. The higher the number is, the stricter the fuzzy search is. I'm hesitant about increasing this number as it might produce problems with other legitimate matches, so the best thing I can do here is to make this number configurable, which I will do. About the specials issue, I'll look into this, and I think #61 might help. |
Sadly that didn't work either. |
Some time ago I thought about a dynamic ratio, adjusting itself based on the length of the file name (the shorter the name, the higher/stricter the ratio) to avoid having too much false positives ( |
Episodes from the show called Mahouka get recognized as Hyouka episodes, in the case that there aren't any other Hyouka episodes around.
Reversely Hyouka episodes don't get recognized as Mahouka episodes.
The text was updated successfully, but these errors were encountered: