Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor detection bug #60

Open
Asnanon opened this issue Sep 3, 2014 · 8 comments
Open

Minor detection bug #60

Asnanon opened this issue Sep 3, 2014 · 8 comments
Labels

Comments

@Asnanon
Copy link

Asnanon commented Sep 3, 2014

Episodes from the show called Mahouka get recognized as Hyouka episodes, in the case that there aren't any other Hyouka episodes around.
Reversely Hyouka episodes don't get recognized as Mahouka episodes.

@z411
Copy link
Owner

z411 commented Sep 3, 2014

Thanks for the report. It seems the results of fuzzy search are becoming apparent.

Can you please give me the filenames of the episodes that get mixed up?

@SleepyMan
Copy link

Well, it's simply because HorribleSubs uses Mahouka as its name, while the official MAL name is "Mahouka Koukou no Rettousei". Making a fuzzy search on alternative titles as well as official titles make this a non-issue, as Mahouka is listed in its alt titles.

@z411
Copy link
Owner

z411 commented Sep 5, 2014

as Mahouka is listed in its alt titles

Which service are you using? MAL doesn't list it as an alternative title.

<series_animedb_id>20785</series_animedb_id>
<series_title>Mahouka Koukou no Rettousei</series_title>
<series_synonyms>; The irregular at magic high school</series_synonyms>

@z411 z411 added the engine label Sep 5, 2014
@SleepyMan
Copy link

Wow, sorry, it really isn't. This is weird, since I modified engine.py to compare to the alternative titles before, it was recognizing it correctly, so I assumed it was in its alternative titles.

Edit: Well, we could add a small amount to the ratio if the file contains a substring of the title/alt-title. E.g. add 0.5 to the ratio if the filename is contained in the title ("Mahouka" in "Mahouka Koukou no Rettousei" or "Argevollen" in "Shirogane no Ishi: Argevollen").

@Asnanon
Copy link
Author

Asnanon commented Sep 5, 2014

Sorry about the delay, the file in question was [HorribleSubs] Mahouka - 12 [720p].mkv, which the search indicated as new Hyouka episode.
There are no problems whatsoever with the recognition of Mahouka. Just the similarity of Houyka and Mahouka seems to produce some errors.
On a related note series that have specials have a similar problem, the episodes of the main series get recognized as special episodes eventhough nothing in the name indicates anything about being a special episode.

@z411
Copy link
Owner

z411 commented Sep 5, 2014

I see. Since "Mahouka" isn't listed as an alternative by the MAL database, even if I tried to remedy this the tracker, instead of confusing it with Hyouka, it just wouldn't find it at all.

The best thing you can do is to set "Mahouka" as the alternative title yourself (can be done in wmal-qt by selecting the show, and going into Show -> Set alternative title), which is a workaround for these specific cases.

The tracker uses a ratio number (currently 0.7) for the fuzzy search. The higher the number is, the stricter the fuzzy search is. I'm hesitant about increasing this number as it might produce problems with other legitimate matches, so the best thing I can do here is to make this number configurable, which I will do.

About the specials issue, I'll look into this, and I think #61 might help.

@Asnanon
Copy link
Author

Asnanon commented Sep 6, 2014

Sadly that didn't work either.
Using the qt interface the setting of an alternative title worked,
although the Mahouka episode still gets recognized as Hyouka episode.
Might be the limit of recognition I guess when two names are too similar
just like in this case. Or as mentioned before with specials.
Makes me personally a bit curious what happens with series that have
longer names which are similar since Ore, Kore, Demo etc. are fairly
popular words to be used lately, especially in LN adaptions.

@Argon-
Copy link

Argon- commented Sep 6, 2014

Some time ago I thought about a dynamic ratio, adjusting itself based on the length of the file name (the shorter the name, the higher/stricter the ratio) to avoid having too much false positives (Mahouka <-> Hyouka) but I never tested this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants