np.genfromtxt #34
Merged
np.genfromtxt #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a dtype for the string turbine name, with a check on the length of the actual name.
jsharpe
reviewed
Jan 25, 2021
| # catch the case where only one turbine location is specified | ||
| if (location_array.ndim < 1): | ||
| location_array = np.reshape(location_array, (1,)) | ||
| for location in location_array: | ||
| idx += 1 | ||
| name = location[0] | ||
| name = str(location[0]) | ||
| if len(name) > 99: print('WARNING: farm.py: turbine name may be truncated '+str(name)) |
There was a problem hiding this comment.
This check will never actually hit because we've already done the truncation as we've passed through np.genfromtxt with the format to limit to 100 characters.
Without manually parsing the file and extracting the name to check this I can't see how we can apply this warning usefully here.
jsharpe
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a dtype for the string turbine name, with a check on the length of the actual name.