encode did when calc digest hash

zCloak-Network · Feb 23, 2023 · c7f2803 · c7f2803
1 parent 2caa873
commit c7f2803
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/angry-coins-shake.md b/.changeset/angry-coins-shake.md
@@ -0,0 +1,5 @@
+---
+'@zcloak/vc': minor
+---
+
+encode did when calc digest
diff --git a/packages/did/src/utils.ts b/packages/did/src/utils.ts
@@ -56,7 +56,7 @@ export function typeTransform(type: KeypairType): VerificationMethodType {
  * @summary
  * encode `didUrl` to a bytes.
  * @description
- * encode `didUrl` to bytes with the identifier as HexString, and the prefix is `did:zk:'. Returns `Uint8Array`.
+ * encode `didUrl` to bytes with the identifier as HexString, and the prefix is `did:zk:`. Returns `Uint8Array`.
  * @example
  * ```typescript
  * import { encodeDidUrl } from '@zcloak/did'

diff --git a/packages/vc/src/digest.ts b/packages/vc/src/digest.ts
@@ -7,6 +7,8 @@ import type { HashType, VerifiableCredentialVersion } from './types';
 
 import { numberToU8a, stringToU8a, u8aConcat, u8aToHex } from '@polkadot/util';
 
+import { encodeDidUrl } from '@zcloak/did';
+
 import { DEFAULT_DIGEST_HASH_TYPE } from './defaults';
 import { HASHER } from './hasher';
 
@@ -73,7 +75,7 @@ export function calcDigest<Version extends VerifiableCredentialVersion>(
   } else {
     encoded = u8aConcat(
       payload.rootHash,
-      stringToU8a(payload.holder),
+      encodeDidUrl(payload.holder),
       numberToU8a((payload as DigestPayload<'1'>).issuanceDate),
       numberToU8a(payload.expirationDate || 0),
       payload.ctype