Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcam restore blocks CLI prompts #29

Closed
za3k opened this issue Mar 25, 2022 · 4 comments
Closed

Webcam restore blocks CLI prompts #29

za3k opened this issue Mar 25, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@za3k
Copy link
Owner

za3k commented Mar 25, 2022

Screenshot of the problem is requested--author uses a tiling window manager and didn't think about this.

Do people find the preview useful? It can just be turned off entirely.

@arcanemachine
Copy link

Here's a screenshot of my lovely ceiling immediately after the window opens: Screenshot_2022-03-25_18-21-16

As you can see, it fills the screen entirely.

A few thoughts on the matter:

  • The preview window is a useful, and perhaps even essential part of the restoration process for the following reasons:

    • The window tells the user that a scanning program is actually running
    • It shows if the QR codes are in the image or if they are out of view of the webcam
    • It shows whether or not you are holding the paper too close (blurry) or too far away (program can't resolve the image).
  • If possible, the size of the window should be adjusted to a reasonable value by default (maybe 640x480, I guess HiDPI monitors could have an issue with that), so that it is unlikely to cover the screen.

  • Perhaps a message could pop up on the terminal telling the user "hey, a window will pop up on screen but we'll show you what's happening on the terminal so make sure to take a look at it as you scan your QR codes". The user could then "press any key to continue" before the preview pops up. This way, the user knows that the terminal window is still worth looking at while the preview window is open.

(Sorry for the delay in responding.)

@za3k
Copy link
Owner Author

za3k commented Mar 26, 2022

As a note to myself, in v1.2 I'm going to add a built-in GUI with scanning previews. So this is only relevant for CLI restores, which is a bigger deal in v1.0 and v1.1.

@za3k za3k added this to the v1.1 milestone Mar 26, 2022
@za3k
Copy link
Owner Author

za3k commented Sep 21, 2022

I don't have a great way to resize or position the window. If you have bright ideas on how, please speak up!

I've added the message you suggest. Let me know if you have better wording suggestions.

==Webcam Restore==

In a second, a second window with a webcam preview will appear on screen.
You may need to resize or move the window to see this terminal.

Progress and hints will appear in the terminal.

Press Enter to start scanning codes.

@za3k za3k closed this as completed in e6bdeac Sep 21, 2022
@arcanemachine
Copy link

I think the warning is sufficient. Once I knew what was happening, I knew how to deal with the problem.

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants