Fixes in cache and pathParams validation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2018 05:58
|
Thanks for your contribution! 🎉 I only used this plugin in an unfinished project and tested it in a very limit situation, you have made it better! koa-joi-swagger@v1.1.1 is published, feel free to create new issues or PRs if you have other problems. |
|
great, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks, you created great library but I faced with the problem of caching routes with same path and different methods. So I tried to fix it in this PR.
Also I fixed validation on pathParams because it didn't work for me at all.
Also please make change in this line https://github.com/zaaack/koa-dec-router/blob/master/src/index.js#L76
uniqBy(routes, r => r.method + r.path)without it test won't work