Add forceformat option #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like at one time the variable referencing the input file was 'path', and later on it was changed to 'json', but the if (options.inplace) block was never updated.
When using jsonlint.com, even invalid JSON is pretty printed. It seemed like a good option to have in the cli version as well. This is simply inserting the char-by-char formatter from https://github.com/umbrae/jsonlintdotcom and adding an option to cli.js.
* fix-inplace-overwriting: Fixing variable name when overwriting input file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy,
Using jsonlint.com, I got used to the behavior that it goes ahead and formats the source even if errors are found. When I started using the jsonlint cli, I noticed that behavior was missing. It seemed like it might be nice to include, so I thought I'd give it a shot. I've just taken Chris Dary's char-by-char formatter and inserted it. I'm hoping that's cool, or that you and he can work it out one way or the other. :)
Also, while working on this, I noticed a variable name wasn't updated properly in cli.js. That change is included in this PR, or I've also created a branch specifically for that change, so I could send a separate PR if you'd rather.
Cheers,
Lance