Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pg_roles instead of pg_authid #1

Merged
merged 5 commits into from
May 2, 2015
Merged

use pg_roles instead of pg_authid #1

merged 5 commits into from
May 2, 2015

Conversation

sboschman
Copy link
Contributor

The view pg_roles provides access to information about database roles. This is simply a publicly readable view of pg_authid that blanks out the password field. (http://www.postgresql.org/docs/9.4/static/view-pg-roles.html)

The view pg_roles provides access to information about database roles. This is simply a publicly readable view of pg_authid that blanks out the password field. (http://www.postgresql.org/docs/9.4/static/view-pg-roles.html)
The view pg_roles provides access to information about database roles. This is simply a publicly readable view of pg_authid that blanks out the password field. (http://www.postgresql.org/docs/9.4/static/view-pg-roles.html)
The view pg_roles provides access to information about database roles. This is simply a publicly readable view of pg_authid that blanks out the password field. (http://www.postgresql.org/docs/9.4/static/view-pg-roles.html)
@cavaliercoder
Copy link
Collaborator

Hi Sverre, thanks for your contribution. I can see the value in your proposed change but unfortunately this would break compatibility with PostgreSQL v8.1 - 8.4 which does not support pg_roles.

Can you think of a way we could default to pg_roles for v9.0+ and fail back to pg_authid for v8?

@cavaliercoder cavaliercoder self-assigned this Apr 11, 2015
@sboschman
Copy link
Contributor Author

I don't have a running 8.1 - 8.4 database to check, so I only checked in the postgres docs before making the change. But according to http://www.postgresql.org/docs/8.1/static/view-pg-roles.html pg_roles should also be supported for v8.

@cavaliercoder
Copy link
Collaborator

Yes, you're correct. I misread the context of 'unsupported versions' in the documentation.
I'll do some integration tests with your PR this week and advise.

Thanks again.

@cavaliercoder
Copy link
Collaborator

I like the new commits you've added (since e3f2fb7), but can please raise future patches as separate pull requests?

cavaliercoder added a commit that referenced this pull request May 2, 2015
use pg_roles instead of pg_authid
@cavaliercoder cavaliercoder merged commit 82ad3ab into zabbix-tools:master May 2, 2015
@cavaliercoder
Copy link
Collaborator

Many thanks sboschman, grateful for your contribution.

@robbrucks robbrucks mentioned this pull request Feb 20, 2017
@msmarziali msmarziali mentioned this pull request May 25, 2017
@alexspeter alexspeter mentioned this pull request Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants