fix issue 17 (#18)

* release v0.1.3

* go mod tidy

* fix issue 17

* Revert "go mod tidy"

This reverts commit adf2b7b.

cmd/cli.go

@@ -25,7 +25,7 @@ const (
 
 const name = "godolint"
 
-const version = "0.1.1"
+const version = "0.1.3"
 
 const usage = `godolint - Dockerfile Linter written in Golang
 

cmd/cli_test.go

@@ -39,7 +39,7 @@ Other Commands:
 		},
 		{
 			command:           "godolint --version",
-			expectedOutStream: "godolint version 0.1.1\n",
+			expectedOutStream: "godolint version 0.1.3\n",
 			expectedErrStream: "",
 			expectedExitCode:  ExitCodeOK,
 		},

linter/rules/dl3013.go

@@ -9,7 +9,7 @@ import (
 
 var regexVersion3013 = regexp.MustCompile(`.+[=|@].+`)
 
-// validateDL3013 Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>`
+// validateDL3013 Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>`.
 func validateDL3013(node *parser.Node) (rst []ValidateResult, err error) {
 	for _, child := range node.Children {
 		if child.Value == RUN {
@@ -26,6 +26,10 @@ func validateDL3013(node *parser.Node) (rst []ValidateResult, err error) {
 				case "&&":
 					isPip, isInstall = false, false
 				default:
+					if strings.HasPrefix(v, "--") || strings.HasPrefix(v, "yamllint") {
+						continue
+					}
+
 					if isPip && isInstall && !regexVersion3013.MatchString(v) && length == len(rst) {
 						rst = append(rst, ValidateResult{line: child.StartLine})
 					}

linter/rules/dl3013_test.go

@@ -30,6 +30,18 @@ RUN pip install django && pip install https://github.com/Banno/carbon/tarball/0.
 			},
 			expectedErr: nil,
 		},
+		{
+			dockerfileStr: `FROM python:3.4
+ARG YAML_LINT_VERSION=v1.26.3
+
+RUN pip install --no-cache-dir yamllint=="${YAML_LINT_VERSION:-v1.26.3}"
+RUN pip install django && pip install https://github.com/Banno/carbon/tarball/0.9.x-fix-events-callback
+`,
+			expectedRst: []ValidateResult{
+				{line: 5},
+			},
+			expectedErr: nil,
+		},
 	}
 
 	for i, tc := range cases {

testdata/DL3013_Dockerfile

@@ -1,3 +1,7 @@
 FROM python:3.4
 RUN pip install django
-RUN pip install https://github.com/Banno/carbon/tarball/0.9.x-fix-events-callback
+RUN pip install https://github.com/Banno/carbon/tarball/0.9.x-fix-events-callback
+
+ARG YAML_LINT_VERSION=v1.26.3
+
+RUN pip install --no-cache-dir yamllint=="${YAML_LINT_VERSION:-v1.26.3}"