Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CI build on pull requests #24

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

tetsuok
Copy link
Contributor

@tetsuok tetsuok commented Jul 7, 2022

I realized that this repo doesn't trigger CI builds on creating pull requests. That's helpful for contributors to understand they need to work if CI fails, and the maintainer doesn't have to manually check whether (1) changed code builds and (2) tests pass.

@zabio3
Copy link
Owner

zabio3 commented Jul 14, 2022

@tetsuok
Thank you for reporting! appreciate!

@zabio3 zabio3 self-requested a review July 14, 2022 08:17
Copy link
Owner

@zabio3 zabio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@zabio3 zabio3 merged commit b54bffe into zabio3:master Jul 14, 2022
@tetsuok tetsuok deleted the run-ci-on-pull-request branch July 14, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants