Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metadata to be set that is passed to the telemetry event #2

Merged
merged 2 commits into from Dec 14, 2022

Conversation

aselder
Copy link
Contributor

@aselder aselder commented Dec 7, 2022

No description provided.

lib/req_telemetry.ex Outdated Show resolved Hide resolved
@aselder
Copy link
Contributor Author

aselder commented Dec 13, 2022

@zachallaun Anything else you need to move this forward? Thanks!

@zachallaun
Copy link
Owner

zachallaun commented Dec 13, 2022 via email

@aselder
Copy link
Contributor Author

aselder commented Dec 13, 2022

Nope, sorry for the delay! Had some family in town but will try to merge and release later today.

On Tue, Dec 13, 2022 at 2:01 PM Andrew Selder @.> wrote: @zachallaun https://github.com/zachallaun Anything else you need to move this forward? Thanks! — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD3BAQOT4JFFPZSHRINGSLWNDBXHANCNFSM6AAAAAASXBOQ4Y . You are receiving this because you were mentioned.Message ID: @.>

No worries!! Hope you enjoyed the time with your family.

@zachallaun zachallaun merged commit af3621d into zachallaun:main Dec 14, 2022
@zachallaun
Copy link
Owner

❤️

@zachallaun
Copy link
Owner

Thanks again for the suggestion and PR @aselder! I added some additional support for including and merging metadata when you make the request and updated the docs a bit. This is now released on hex as 0.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants