-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build using release flag --> 2x/3x performance #28
Comments
I'll get right on it. Focus for v3.6.2 was making |
Will it be released as a v3.6.2 hotfix or should we wait till v3.6.3? 😋 |
I'm about to release it as v3.6.3 🚀 |
BOOM 💥 |
Please please check it with objdump that it all indeed inlined in final build. I had issues with it and couldn't do it for unknown for me reason. |
I'm going to keep your original issue open @Komzpa until we figure out how to get h3 inlined. For now the performance improvements from release flag is worth a release. |
As mentioned at #23 (comment) , adding
-DCMAKE_BUILD_TYPE=Release
to the makefile results in 2x/3x improvements as per @Komzpa 's benchmarks at uber/h3#326Current
With Release flag
Latest build v3.6.2 does not use this flag
The text was updated successfully, but these errors were encountered: