allow empty version prefix #10
Conversation
|
Hello, @marinakr! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
lib/mix/tasks/git_ops.release.ex
Outdated
| @@ -131,8 +130,7 @@ defmodule Mix.Tasks.GitOps.Release do | |||
| last_version_after = GitOps.Version.last_version_greater_than(tags, tag, prefix) | |||
|
|
|||
| if last_version_after do | |||
| commit_messages_for_changelog = | |||
| GitOps.Git.commit_messages_since_tag(repo, last_version_after) | |||
| commit_messages_for_changelog = GitOps.Git.commit_messages_since_tag(repo, last_version_after) | |||
There was a problem hiding this comment.
Nested modules could be aliased at the top of the invoking module.
lib/mix/tasks/git_ops.release.ex
Outdated
| @@ -82,8 +82,7 @@ defmodule Mix.Tasks.GitOps.Release do | |||
|
|
|||
| config_types = GitOps.Config.types() | |||
|
|
|||
| {commit_messages_for_version, commit_messages_for_changelog} = | |||
| get_commit_messages(repo, prefix, tags, opts) | |||
| {commit_messages_for_version, commit_messages_for_changelog} = get_commit_messages(repo, prefix, tags, opts) | |||
There was a problem hiding this comment.
Line is too long (max is 100, was 112).
lib/mix/tasks/git_ops.release.ex
Outdated
| @@ -100,7 +99,7 @@ defmodule Mix.Tasks.GitOps.Release do | |||
| ) | |||
| end | |||
|
|
|||
| new_version = String.trim_leading(prefixed_new_version, prefix) | |||
| new_version = if "" != prefix, do: String.trim_leading(prefixed_new_version, prefix), else: prefixed_new_version | |||
There was a problem hiding this comment.
Line is too long (max is 100, was 116).
lib/mix/tasks/git_ops.release.ex
Outdated
| @@ -131,8 +130,7 @@ defmodule Mix.Tasks.GitOps.Release do | |||
| last_version_after = GitOps.Version.last_version_greater_than(tags, tag, prefix) | |||
|
|
|||
| if last_version_after do | |||
| commit_messages_for_changelog = | |||
| GitOps.Git.commit_messages_since_tag(repo, last_version_after) | |||
| commit_messages_for_changelog = GitOps.Git.commit_messages_since_tag(repo, last_version_after) | |||
There was a problem hiding this comment.
Line is too long (max is 100, was 102).
Pull Request Test Coverage Report for Build 71
💛 - Coveralls |
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/zachdaniel/git_ops/pulls/10. |
Contributor checklist
For example:
fix: Multiply by appropriate coefficient, orfeat(Calculator): Correctly preserve historyAny explanation or long form information in your commit message should be
in a separate paragraph, separated by a blank line from the primary message