Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow no prefix + pass credo #11

Merged
merged 5 commits into from
Jan 22, 2019
Merged

Conversation

marinakr
Copy link
Contributor

Contributor checklist

  • My commit messages follow the Conventional Commit Message Format
    For example: fix: Multiply by appropriate coefficient, or
    feat(Calculator): Correctly preserve history
    Any explanation or long form information in your commit message should be
    in a separate paragraph, separated by a blank line from the primary message
  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 15 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/zachdaniel/git_ops/pulls/11.

@coveralls
Copy link

coveralls commented Jan 22, 2019

Pull Request Test Coverage Report for Build 75

  • 27 of 32 (84.38%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 87.368%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mix/tasks/git_ops.release.ex 17 22 77.27%
Totals Coverage Status
Change from base Build 69: 2.3%
Covered Lines: 166
Relevant Lines: 190

💛 - Coveralls

@@ -100,10 +106,13 @@ defmodule Mix.Tasks.GitOps.Release do
)
end

new_version = String.trim_leading(prefixed_new_version, prefix)
new_version =
if "" != prefix,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, purely stylistically, I'd rather see this as:

new_version =
  if prefix != "" do
    String.trim_leading(prefixed_new_version, prefix)
  else
    prefixed_new_version
  end

@zachdaniel
Copy link
Owner

Thank you so much for all the cleanup you did in addition to this PR. Great stuff! I had one stylistic piece of feedback, but aside from that this looks great. I'll approve/merge once that change is made (or if you disagree with it feel free to discuss).

@zachdaniel
Copy link
Owner

One more thing, if you could just remove the version change, as well as changes to the changelog. My workflow is to do the release and generate the changelog after merging the PR. Thanks!

@marinakr
Copy link
Contributor Author

done

@zachdaniel zachdaniel merged commit 51e5e5c into zachdaniel:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants