Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial mix project check #6

Merged
merged 7 commits into from
Dec 3, 2018

Conversation

tomplarge
Copy link
Contributor

Wanted to put this up so we have it since it is a crucial bug. Didn't know if it was possible to access the mix args in the before_compile step, so I moved it out, but if there is a way I'll put it change it.

Contributor checklist

  • My commit messages follow the Conventional Commit Message Format
    For example: fix: Multiply by appropriate coefficient, or
    feat(Calculator): Correctly preserve history
    Any explanation or long form information in your commit message should be
    in a separate paragraph, separated by a blank line from the primary message
  • Bug fixes include regression tests
  • Features include unit/acceptance tests


@doc false
def run(args) do
opts = get_opts(args)

GitOps.Config.mix_project_check(opts)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested modules could be aliased at the top of the invoking module.

@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 68

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.7%) to 86.702%

Files with Coverage Reduction New Missed Lines %
lib/mix/tasks/git_ops.release.ex 1 74.58%
Totals Coverage Status
Change from base Build 66: 1.7%
Covered Lines: 163
Relevant Lines: 188

💛 - Coveralls

@zachdaniel zachdaniel merged commit ac2b0f2 into zachdaniel:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants