Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to filter through merchant, possible to get product… #12

Closed
wants to merge 1 commit into from

Conversation

lukeses
Copy link

@lukeses lukeses commented Apr 12, 2017

…s sold only by amazon

@zachgarwood
Copy link
Collaborator

@lukeses This is great, thanks! How would you feel about expanding the scope of this change and incorporating all of the available request parameters in the ItemSearch operation?

@@ -19,7 +19,8 @@ defmodule AmazonProductAdvertisingClient.ItemSearch do
"ResponseGroup": nil,
"SearchIndex": nil,
"Sort": nil,
"Title": nil
"Title": nil,
"MerchantId": nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency's sake, please keep the parameters alphabetized.

@zachgarwood zachgarwood self-requested a review April 12, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants