update astro to v1 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! I’ll re-run with the same hardware and leave an update here when the blog post is updated |
zachleat
added a commit
that referenced
this pull request
Aug 10, 2022
|
Nice! Thanks for the quick update. The rest of the slowdown seems to get exponentially worse as the project grows, which makes me think its our internal Vite bundler having to treat each page as a new entrypoint in a larger-and-larger graph. I think that's where we'll focus next. |
|
@zachleat curious: how much memory are you giving Node on the hardware you're running this on? Have you tried running with something like |
|
Yeah, this is just using defaults—I think that makes the most sense for the context that most projects will operate in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, this bumps the Astro templates to v1.0.1 to get the latest and greatest speed improvements by @bholmesdev.
I also updated the
astro-with-mdxbenchmark, but since this is a test of.mdfiles and not.mdxfiles I don't think that benchmark is really testing anything, aka the two benchmarks are basically identical and you should be safe to remove one.